jakob.schratter/SciFEM_Schratter
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

response 3

Browse source
This commit is contained in:
Gundolf Haase 2025-11-12 13:58:25 +01:00
commit 45fdb92841
5 changed files with 337 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
ex3_benchmarks/Makefile
View file

@ -13,7 +13,9 @@ COMPILER=GCC_
# COMPILER=PGI_
SOURCES = main.cpp benchmarks.cpp benchmark_tests.cpp factorization_solve.cpp factorization_solve_tests.cpp
#SOURCES = main.cpp benchmarks.cpp benchmark_tests.cpp factorization_solve.cpp factorization_solve_tests.cpp
# GH
SOURCES = main.cpp benchmarks.cpp benchmark_tests.cpp factorization_solve.cpp factorization_solve_tests.cpp vdop.cpp getmatrix.cpp
OBJECTS = $(SOURCES:.cpp=.o)
PROGRAM = main.${COMPILER}

4
ex3_benchmarks/benchmark_tests.cpp
View file

@ -211,7 +211,7 @@ vector<double> test_C(const size_t &NLOOPS, const size_t &L, const size_t &M, co
// Do calculation
vector<double> C(M*N);
double check;
double check_sum;
double check_sum; // GH: initialize
for (size_t i = 0; i < NLOOPS; ++i)
{
@ -330,4 +330,4 @@ vector<double> test_D(const size_t &NLOOPS, const size_t &N, const size_t &p)
return vector<double>{t_diff, Gflops, MemBandwidth};
}
}

13
ex3_benchmarks/gh_response.txt Normal file
View file

@ -0,0 +1,13 @@
* added ../GCC_default.mk and ../CLANG_default.mk into your repository
* missing objects in Makefile, see Makefile:18 [-1]
* benchmark_tests.cpp:214
double check_sum // GH: initialize!
* Some comprehensive documents on results would be good.
* benchmarks.cpp
MatMat(): swao j and k loop // should be faster
minor remarks in pdf.
* make codecheck COMPILER=CLANG_ > codecheck_gh.out