diff --git a/directory.js b/directory.js index bda4837..2875c4e 100644 --- a/directory.js +++ b/directory.js @@ -1,66 +1,66 @@ -const C = document.createElement; -// const G = document.getElementById; +const $C = (e) => document.createElement(e); +const $G = (e) => document.getElementById(e); const ordNrRegex = /.*pOrgNr=([0-9]+).*/gm; const personalIDRegex = /.*pStPersonNr=([0-9]+).*/gm; function appendLink(nonEmptyGroup) { - if (document.getElementById("kf-trombi_row")) return; + if ($G("kf-trombi_row")) return; - var row_header = document.createElement("th"); + var row_header = $C("th"); row_header.textContent = "Trombi"; row_header.classList.add("kf-trombi_row_header"); - var row_links = document.createElement("td"); + var row_links = $C("td"); if (nonEmptyGroup) { - var link = document.createElement("a"); + var link = $C("a"); link.id = "kf-trombi_link"; link.textContent = "Show"; link.href="#"; link.addEventListener("click", toggleTrombi); - const inputContainer = document.createElement("span"); + const inputContainer = $C("span"); inputContainer.id = "kf-trombi_input_container"; inputContainer.classList.add("hidden"); - const sliderContainer = document.createElement("span"); + const sliderContainer = $C("span"); sliderContainer.id = "kf-trombi_slider_container"; - var slider = document.createElement("input"); + var slider = $C("input"); slider.id = "kf-trombi_columns_slider"; slider.type = "range"; slider.value = 5; slider.min = 3; slider.max = 8; - var column_nr = document.createElement("span"); + var column_nr = $C("span"); column_nr.id = "kf-trombi_column_nr"; column_nr.textContent = slider.value; - var column_label = document.createElement("span"); + var column_label = $C("span"); column_label.textContent = " columns"; slider.addEventListener("input", (event) => { column_nr.textContent = slider.value; - const trombi = document.getElementById("kf-trombi_trombi"); + const trombi = $G("kf-trombi_trombi"); trombi.classList.remove( "kf-trombi_trombi_3", "kf-trombi_trombi_4", "kf-trombi_trombi_5", "kf-trombi_trombi_6", "kf-trombi_trombi_7", "kf-trombi_trombi_8" ); trombi.classList.add(`kf-trombi_trombi_${slider.value}`); }) sliderContainer.append(slider, column_nr, column_label); - enhanced_checkbox = document.createElement("input"); + enhanced_checkbox = $C("input"); enhanced_checkbox.id = "kf-trombi_enhanced_checkbox"; enhanced_checkbox.type = "checkbox"; enhanced_checkbox.checked = true; - var enhance_label = document.createElement("label"); + var enhance_label = $C("label"); enhance_label.textContent = " Enhance for printing"; enhance_label.htmlFor = "kf-trombi_enhanced_checkbox"; enhanced_checkbox.addEventListener("input", (event) => { - const trombi = document.getElementById("kf-trombi_trombi"); + const trombi = $G("kf-trombi_trombi"); trombi.classList.toggle('kf-trombi_enhanced'); }) inputContainer.append(sliderContainer, enhanced_checkbox, enhance_label); @@ -69,12 +69,12 @@ function appendLink(nonEmptyGroup) { row_links.textContent = "empty group!" } - var tr = document.createElement("tr"); + var tr = $C("tr"); tr.classList.add("coNavGroup"); tr.append(row_header, row_links); tr.id = "kf-trombi_row"; - const nav = document.getElementById("idPageNavi"); + const nav = $G("idPageNavi"); nav.tBodies[0].append(tr); } @@ -88,14 +88,14 @@ function extractIDs(url) { function generateCard(student, col) { const url = `/kfu_online/pl/ui/$ctx/wbstudkart.wbShowImage?pOrgNr=${student.ids.org}&pStPersonNr=${student.ids.perso}&pType=U` - const d = document.createElement("div"); + const d = $C("div"); d.classList.add("kf-trombi_card"); - const img = document.createElement("img"); + const img = $C("img"); img.classList.add("kf-trombi_trombi_img"); img.src = url; - const name_div = document.createElement("div"); + const name_div = $C("div"); name_div.textContent = `${student.firstname} ${student.lastname}`; d.append(img, name_div); @@ -103,10 +103,10 @@ function generateCard(student, col) { } function toggleTrombi() { - const trombi = document.getElementById("kf-trombi_trombi"); - const form = document.getElementById("idTNListe"); - const link = document.getElementById("kf-trombi_link"); - const inputContainer = document.getElementById("kf-trombi_input_container"); + const trombi = $G("kf-trombi_trombi"); + const form = $G("idTNListe"); + const link = $G("kf-trombi_link"); + const inputContainer = $G("kf-trombi_input_container"); trombi.classList.toggle("hidden"); form.classList.toggle("hidden"); if(inputContainer.classList.toggle("hidden")) { @@ -117,17 +117,17 @@ function toggleTrombi() { } function generateTrombi() { - var trombi = document.getElementById("kf-trombi_trombi"); + var trombi = $G("kf-trombi_trombi"); if (trombi) { trombi.remove(); } - const slider = document.getElementById("kf-trombi_columns_slider"); - trombi = document.createElement("div"); + const slider = $G("kf-trombi_columns_slider"); + trombi = $C("div"); trombi.id = "kf-trombi_trombi"; trombi.classList.add("hidden"); trombi.classList.add(`kf-trombi_trombi_${slider.value}`); trombi.classList.add("kf-trombi_enhanced"); - const form = document.getElementById("idTNListe"); + const form = $G("idTNListe"); - const table_body = document.getElementById("idTNVWTable").tBodies[0]; + const table_body = $G("idTNVWTable").tBodies[0]; const student_list = []; for (let row of table_body.children) { @@ -146,10 +146,10 @@ function generateTrombi() { } // reset -if (document.getElementById("kf-trombi_trombi")) { - document.getElementById("idTNListe").classList.remove("hidden"); - document.getElementById("kf-trombi_trombi").remove(); - document.getElementById("kf-trombi_row").remove(); +if ($G("kf-trombi_trombi")) { + $G("idTNListe").classList.remove("hidden"); + $G("kf-trombi_trombi").remove(); + $G("kf-trombi_row").remove(); } // only enable on non-empty groups